Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-run option #1931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add --no-run option #1931

wants to merge 1 commit into from

Conversation

hwchen
Copy link
Contributor

@hwchen hwchen commented Feb 6, 2025

--no-run option.

For commands which may run executable after building (compile-test, compile-bench, compile-run, and clean-run, skip the "run" step.

See #1930

@hwchen
Copy link
Contributor Author

hwchen commented Feb 6, 2025

@lerno I know you'd also suggested --build-only. I saw that it's a bit similar to the command compile-only though.

Also, I think you may have mentioned some other concerns with this option in discord, but I'm not sure if they'll conflict with this implementation.

@tomaskallup
Copy link
Contributor

Does it make sense to have a --no-run option for compile-run? That's essentially just an alias to compile right?

@hwchen
Copy link
Contributor Author

hwchen commented Feb 6, 2025

I agree it seems weird to have it for compile-run, but I also think it would feel inconsistent to disallow it.

@hwchen
Copy link
Contributor Author

hwchen commented Feb 7, 2025

Looks like there's been a refactor around how build options are printed. But I don't know if that means the approach in this PR should change.

If we keep this approach, I'll update the PR

@hwchen hwchen force-pushed the hwchen/no-run branch 2 times, most recently from 5fd6bd1 to 90076e8 Compare February 7, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants