Move streaming reader out of Blob
into a dedicated BufReader
class
#197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extracts the streaming reader logic from
Blob
and into a newBufReader
class. This change removes A LOT of clutter fromBlob
while clearly separating the streaming concerns into a dedicated component.The
BufReader
encapsulates the asynchronous task of reading data from a underlying source. It takes aRead
function as a constructor parameter, allowing callers to specify how bytes are fetched into the provided buffer. TheRead
function must return the number of bytesread
and indicate completion by settingdone
when there is no more data to read.This refactoring is a preparatory work for a streaming
FormDataEncoder
, as discussed here: #191 (comment).