Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to [email protected] #174

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Update to [email protected] #174

merged 4 commits into from
Jan 21, 2025

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Nov 1, 2024

This adds a host implementation for [email protected], and sets it to the default.

Resolves #172.

@tschneidereit
Copy link
Member

Incidentally, I created a patch making it easier to support multiple WASI versions just recently. I just opened #175 to land that separate from the work I did it for (which you can see here), and think it'd probably make sense to rebase this PR on top of it to reduce code duplication.

Also, it'd be nice to document what changed in terms of functionality, if anything.

@guybedford
Copy link
Contributor Author

Absolutely fine to rebase this, I just needed to get it together for the ComponentizeJS release which has been made now on this branch, but we can refactor further no problem.

@guybedford
Copy link
Contributor Author

@tschneidereit I understand you have a better architecture in mind here, but for what it is worth I've rebased this PR to main now.

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should be able to shrink this diff substantially by not duplicating all of the host_api implementation, and most everything else except for the WIT and the generated bindings.

You can see an approach to doing this in my branch for the http-body-append (not-yet) proposal here: https://github.com/bytecodealliance/StarlingMonkey/tree/wasi-http-body-append/host-apis/wasi-0.2.x-pre

Happy to talk through all of this in case it's not clear—or also to take this on myself so we have an example in-tree.

@tschneidereit
Copy link
Member

@guybedford I pushed a new commit here that implements the deduplication I suggested earlier. As you can see, the diff to main becomes substantially smaller with this change applied.

Copy link
Contributor Author

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Happy to get the similar 0.2.3 going when we do the upgrade across Jco and ComponentizeJS soon.

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but would like an r+ from @guybedford as well, given my substantial additions to the PR itself.

@tschneidereit
Copy link
Member

Actually, I can't select Guy as a formal reviewer, but he gave an LGTM above.

@tschneidereit tschneidereit merged commit 2aba685 into main Jan 21, 2025
5 checks passed
@tschneidereit tschneidereit deleted the wasi-022 branch January 21, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASI 0.2.1, 0.2.2 bindings
2 participants