Skip to content

Revert recent changes in cpp_int/bitwise #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ckormanyos
Copy link
Member

@ckormanyos ckormanyos commented May 19, 2025

The purpose of this PR is to revert recent changes in cpp_int/bitwise.hpp in order to see if these are the cause of the undefined behavior detections in an unrelated Math PR.

Cc: @mborland and @jzmaddock

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (9de48c7) to head (ccdaf10).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #689     +/-   ##
=========================================
- Coverage     94.1%   94.1%   -0.0%     
=========================================
  Files          280     280             
  Lines        29074   29074             
=========================================
- Hits         27349   27347      -2     
- Misses        1725    1727      +2     
Files with missing lines Coverage Δ
include/boost/multiprecision/cpp_int/bitwise.hpp 85.2% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de48c7...ccdaf10. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckormanyos
Copy link
Member Author

Closing since this is not needed

@ckormanyos ckormanyos closed this May 26, 2025
@ckormanyos ckormanyos deleted the revert_bitwise branch May 26, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant