Feature/from files #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for contributing! Just want to let you know that I will only be back in ~2 weeks to really have a look into this. |
|
@bluenote10 did you make it back? Nov 2019...? |
|
Oh sorry I completely forgot about that one. I don't know, should we just merge it or is it no longer valid? I'm not actively using Nim any more, and I don't have the capacity to really maintain this (and without a proper CI it is hard to judge). |
|
I've sent you a linkedin message for a more private conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New to nim...was looking for a way to create one DF from files adhering to a pattern. I am working with a directory of files where one file = one DF, and I want to "append" them all together. I tried to make "fromFiles" repeatedly yield from a walkPattern iterator that repeatedly calls "fromFile", but I couldn't get that to work because I suck at nim.
I wanted offer a very small (albeit incomplete) addition and get feedback on what I did. Is there a more efficient way? Is this not idiomatic nim? Is there a more straightforward approach? I figured someone would get the gist of what I am doing and say "wtf, why would you do it like that?" and offer a better solution.
Overall, great code and easy to read! Very helpful library! Just trying to help...