Skip to content

added rose pine moon theme #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

shivamchhuneja
Copy link

@shivamchhuneja shivamchhuneja commented May 5, 2025

Added Rose Pine Moon theme.

Background image from Freepik (following the other images.)

@shivamchhuneja shivamchhuneja marked this pull request as draft May 5, 2025 09:32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a " missing at the end, it doesn't close properly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad, checked and fixed and tested

@shivamchhuneja shivamchhuneja marked this pull request as ready for review May 5, 2025 12:27
.DS_Store Outdated
Copy link
Contributor

@Kasui92 Kasui92 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think .DS_Store files are needed in the script.
You can remove them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for flagging this, added exclusions on my end as well

@Kasui92
Copy link
Contributor

Kasui92 commented May 8, 2025

In #451 I update Zellij themes with the new specs.

In case it gets merged, I think this theme could be updated too. There you can find a link to a PR that updates rose-pine themes and there is also one for the moon variant.

@shivamchhuneja
Copy link
Author

Just checked your PR as well, will keep an eye on that one and as soon as we move out of the legacy in Zellij, I'll update this one too.

@dhh
Copy link
Member

dhh commented May 18, 2025

Appreciate the effort, but I looked at this when originally setting up the themes, and I don't think it offers enough variance over tokyo night and catpuccin to warrant inclusion by default.

@dhh dhh closed this May 18, 2025
@shivamchhuneja
Copy link
Author

Noted and a valid point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants