-
Notifications
You must be signed in to change notification settings - Fork 624
added rose pine moon theme #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a " missing at the end, it doesn't close properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my bad, checked and fixed and tested
.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think .DS_Store files are needed in the script.
You can remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thank you for flagging this, added exclusions on my end as well
In #451 I update Zellij themes with the new specs. In case it gets merged, I think this theme could be updated too. There you can find a link to a PR that updates |
Just checked your PR as well, will keep an eye on that one and as soon as we move out of the legacy in Zellij, I'll update this one too. |
Appreciate the effort, but I looked at this when originally setting up the themes, and I don't think it offers enough variance over tokyo night and catpuccin to warrant inclusion by default. |
Noted and a valid point |
Added Rose Pine Moon theme.
Background image from Freepik (following the other images.)