Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add takeover based HUP script #407

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add takeover based HUP script #407

merged 1 commit into from
Nov 29, 2024

Conversation

kb2ma
Copy link
Contributor

@kb2ma kb2ma commented Nov 20, 2024

This script is equivalent to upgrade-2.x.sh, but for takeover based HUP. This script is derived from upgrade-2.x.sh, but removes unnecessary functionality. It also aims to be a model for a script implementation but avoiding gratuitous changes to the upgrade-2.x.sh original.

I am looking for higher level comments on the approach at this point. I have added some questions in the code. Don't mind the individual commits. I will squash them later.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
@kb2ma kb2ma requested review from jakogut, alexgg and mtoman November 20, 2024 03:20
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
upgrade-takeover.sh Outdated Show resolved Hide resolved
@kb2ma kb2ma force-pushed the upgrade-via-takeover branch from 39ac322 to de7f373 Compare November 29, 2024 05:09
@kb2ma kb2ma marked this pull request as ready for review November 29, 2024 05:10
@kb2ma kb2ma requested a review from alexgg November 29, 2024 05:10
@flowzone-app flowzone-app bot enabled auto-merge November 29, 2024 05:11
@kb2ma kb2ma disabled auto-merge November 29, 2024 05:11
@kb2ma
Copy link
Contributor Author

kb2ma commented Nov 29, 2024

@alexgg Fixed up from your review and rebased. All changes are in the final commit. In addition to your review, I did these things:

  • Renamed "takeover_path" to "work_dir". It's more descriptive, especially since adding the cleanup function
  • Added some options to the takeover binary to accommodate how it works now

If it looks OK, I'll squash down to a single commit for final approval.

Change-type: patch
Signed-off-by: Ken Bannister <[email protected]>
@kb2ma kb2ma force-pushed the upgrade-via-takeover branch from de7f373 to 9997307 Compare November 29, 2024 15:46
@flowzone-app flowzone-app bot merged commit a22e568 into master Nov 29, 2024
52 checks passed
@flowzone-app flowzone-app bot deleted the upgrade-via-takeover branch November 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants