-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add takeover based HUP script #407
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
39ac322
to
de7f373
Compare
@alexgg Fixed up from your review and rebased. All changes are in the final commit. In addition to your review, I did these things:
If it looks OK, I'll squash down to a single commit for final approval. |
Change-type: patch Signed-off-by: Ken Bannister <[email protected]>
de7f373
to
9997307
Compare
This script is equivalent to
upgrade-2.x.sh
, but for takeover based HUP. This script is derived fromupgrade-2.x.sh
, but removes unnecessary functionality. It also aims to be a model for a script implementation but avoiding gratuitous changes to theupgrade-2.x.sh
original.I am looking for higher level comments on the approach at this point. I have added some questions in the code. Don't mind the individual commits. I will squash them later.