feat: 扩展轮播图组件支持视频和左右滑动 #11528
Open
feat: 扩展轮播图组件支持视频和左右滑动 #11528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkiroc
reviewed
Jan 23, 2025
| if (multiple && multiple.count > 1) { | ||
| const container = this.wrapperRef.current; | ||
| if (container) { | ||
| const items = container.getElementsByClassName('Carousel-item'); |
There was a problem hiding this comment.
没太理解这一段是为了处理什么问题，另外在react尽量不要用dom操作，其次这里应该始终是获取不到的，class都会被加上前缀，比如cxd-Carousel-item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How