-
Notifications
You must be signed in to change notification settings - Fork 50
chore: add user name character warning #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds a warning log when potentially invalid characters are used in a username.
7f45585
to
a42032e
Compare
src/main/java/com/aws/greengrass/lifecyclemanager/KernelCommandLine.java
Show resolved
Hide resolved
To test this change I deployed the nucleus onto a windows instance and attempted to boot it up with the following command
Log message seen in the greengrass.log file
|
LGTM but how are you creating this pull request? Are you creating a fork of this repo and creating a PR out of that? That will not work as it will not be able to run the CI for unit and integ tests. You need clone this repo, create a new branch for your work and create a PR from that. |
Issue #, if available:
Description of changes:
Adds a warning log when potentially
invalid characters are used in a username.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
This change aims to raise awareness around invalid user names which can cause component failures.
For Linux see this (best doc I could find).
For Windows see this.
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.