Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From asdf version v0.16.0, this plugin breaks and fails when trying to install a PHP version. This PR introduces a fix that addresses this issue for asdf >= v0.16.0 while ensuring backward compatibility with older versions of asdf. Specifically, the default value of
ASDF_CONCURRENCY
as 'auto' breaks the PHP compiler.Additionally, I recommend the maintainers set up the
bin/help.deps
script in the repository to define platform-specific dependencies, as detailed in the asdf plugin documentation. This will help list and check missing dependencies before attempting to compile new PHP versions.Years ago, I faced a similar issue while building my own PHP version manager, which you can find here: howiphp. I encountered the same challenge when listing and verifying missing dependencies prior to compiling PHP versions.
Changes Introduced:
Testing: