Skip to content

Connectors Debugger V2 to pass through all types of mapping problems #7591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

andrewmcgivery
Copy link
Contributor

@andrewmcgivery andrewmcgivery commented May 29, 2025

Connectors Debugger V2 to pass through all types of mapping problems

Open questions....

  1. Do I actually need all the clone and cloned that I currently have? Rust seems to think so but open to suggestions
  2. What is the impact of some of this code at run time when debug is not enabled? Is it worth passing debug all over to avoid some of the mapping of errors to problems? (thinking no since it's pretty trivial code but open to opinions)

Relies on https://github.com/mdg-private/studio-ui/pull/12112 (that needs to be in prod before this change lands in a Router release!)


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Copy link
Contributor

@andrewmcgivery, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented May 29, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 06f03750bd7307154435c8d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants