adding @fromContext directive validation
#7563
Draft
+2,495
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add complete @fromcontext directive validation in from_context.rs validator - Implement field value type validation with support for: - Single field selections and nested field selections - Type compatibility checking between context and argument types - Multiple context locations with duck typing support - Inline fragment validation with type conditions - Interface object detection and error reporting - Add validation rules for @fromcontext usage: - Deny usage on abstract types (interfaces/unions directly) - Deny usage on interface implementation fields - Require context to be defined via @context directive - Require at least one resolvable key on types using contextual args - Deny default values on @fromcontext arguments - Deny usage on directive definition arguments - Add comprehensive test coverage with 35+ test cases covering: - Basic success cases and error conditions - Type validation edge cases and compatibility rules - Selection format validation (aliases, directives, multiple selections) - Context reference validation and type condition matching - Add proper port notes documenting relationship to JavaScript test suite - Export validate_from_context_directives function from validators module - Update schema upgrader and subgraph module to integrate validation 🎫 FED-497
|
@clenfest, please consider creating a changeset entry in |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: cade0146dd00b11f89cb2fe4 |
goto-bus-stop
changed the title
@fromContext directive validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fromContextdirective validation in from_context.rs validator@fromContextusage:@contextdirective@fromContextarguments🎫 FED-497