Skip to content
This repository has been archived by the owner on Jul 10, 2019. It is now read-only.

Fix field not found when alias field resolve falsy #337

Closed
wants to merge 1 commit into from

Conversation

trungtin
Copy link

When aliasedNode resolve falsy value (0, false, null) and preAliasingNode resolve undefined then the error field not found appears, this should fixes it.

When aliasedNode resolve falsy value (0, false, null) and preAliasingNode resolve undefined then the error `field not found` appear, this should fixed it.
@apollo-cla
Copy link

@trungtin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@trungtin
Copy link
Author

close as duplicate of #303

@trungtin trungtin closed this Dec 23, 2018
@codecov-io
Copy link

codecov-io commented Dec 23, 2018

Codecov Report

Merging #337 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage      95%   95.12%   +0.12%     
==========================================
  Files           2        2              
  Lines          80       82       +2     
  Branches       22       22              
==========================================
+ Hits           76       78       +2     
  Misses          1        1              
  Partials        3        3
Impacted Files Coverage Δ
packages/apollo-link-state/src/index.ts 93.84% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34774d8...f7ecf7a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants