Skip to content

Bump minimal Python version to 3.10 in worflows #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Mar 31, 2025

Downstream repos updates:
apify/crawlee-python#1124
...
TODO: add more downstream projects and merge this only once all downstream projects are ready

@Pijukatel Pijukatel added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 31, 2025
@github-actions github-actions bot added this to the 111th sprint - Tooling team milestone Mar 31, 2025
@Pijukatel Pijukatel marked this pull request as draft March 31, 2025 11:24
@B4nan
Copy link
Member

B4nan commented Mar 31, 2025

just keep in mind this is a breaking change for every single project using those workflows. i am actually quite surprised we rely on shared workflows from here, this is something that i would rather see done from inside each project, separately, adding the mention to the changelog and explicitly stating that the PR is breaking, enforcing correct version bump.

(no problems with doing this, but it needs to be properly communicated in both the project version and the changelog/release notes)

@Pijukatel
Copy link
Contributor Author

just keep in mind this is a breaking change for every single project using those workflows. i am actually quite surprised we rely on shared workflows from here, this is something that i would rather see done from inside each project, separately, adding the mention to the changelog and explicitly stating that the PR is breaking, enforcing correct version bump.

(no problems with doing this, but it needs to be properly communicated in both the project version and the changelog/release notes)

Yes, and each project will have some issues to fix with this bump. So it will not be trivial bump. No need to do it now, I was just getting an idea of the amount of work needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants