Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50977][CORE] Enhance availability of logic performing aggregation of accumulator results #49618

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

costas-db
Copy link
Contributor

@costas-db costas-db commented Jan 23, 2025

What changes were proposed in this pull request?

In this PR we introduce a minor refactor that enhances the availability of the functionality used to perform aggregation of accumulator results.

Why are the changes needed?

These changes make the aggregation logic accessible from other modules which enables various memory and disk optimizations.

Does this PR introduce any user-facing change?

No

How was this patch tested?

This is a minor refactor. No new code has been added, therefore no new tests are needed.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon HyukjinKwon marked this pull request as draft January 24, 2025 00:25
@HyukjinKwon HyukjinKwon changed the title Push initial restructure [WIP] Push initial restructure Jan 24, 2025
@costas-db costas-db changed the title [WIP] Push initial restructure [SPARK-50977] Enhance availability of logic performing aggregation of accumulator results Jan 24, 2025
@costas-db costas-db marked this pull request as ready for review January 24, 2025 19:33
Copy link
Contributor

@utkarsh39 utkarsh39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove these from SQLMetrics class to avoid code deduplication?

@HyukjinKwon HyukjinKwon changed the title [SPARK-50977] Enhance availability of logic performing aggregation of accumulator results [SPARK-50977][CORE] Enhance availability of logic performing aggregation of accumulator results Jan 25, 2025
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too but let's make sure the build is green before getting this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants