Skip to content

ostest/wdog: Update wdog_test. #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fix-Point
Copy link
Contributor

Summary

This PR added periodic wdog testing and updated the wdog_test to adapt to the semantic changes of the wd_start.

Impact

This PR only affects the ostest/wdog_test.

Testing

Tested on QEMU/x86_64, sim and QEMU/riscv32.

This commit added periodic wdog testing.

Signed-off-by: ouyangxiangzhen <[email protected]>
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fix-Point :-)

The changes are okay, but we have CI error, do we also need to update citest to match the wdog test in ostest update @lupyuen ? Lets verify that before merging please :-)

- generated json report: /github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/logs/sim/sim/pytest.json -
=========================== short test summary info ============================
FAILED test_os/test_os.py::test_ostest - assert -2 == 0
FAILED test_os/test_os.py::test_mm - AttributeError: type object 'EOF' has no...
FAILED test_os/test_os.py::test_cxxtest - AttributeError: type object 'EOF' h...
FAILED test_os/test_os.py::test_scanftest - AttributeError: type object 'EOF'...
FAILED test_os/test_os.py::test_getprime - AttributeError: type object 'EOF' ...
FAILED test_os/test_os.py::test_stdio - AttributeError: type object 'EOF' has...
FAILED test_os/test_os.py::test_fs_test - AttributeError: type object 'EOF' h...
FAILED test_os/test_os.py::test_psram_test - AttributeError: type object 'EOF...
ERROR test_os/test_os.py::test_ostest - AttributeError: type object 'EOF' has...
ERROR test_os/test_os.py::test_mm - AttributeError: type object 'EOF' has no ...
ERROR test_os/test_os.py::test_cxxtest - AttributeError: type object 'EOF' ha...
ERROR test_os/test_os.py::test_scanftest - AttributeError: type object 'EOF' ...
ERROR test_os/test_os.py::test_getprime - AttributeError: type object 'EOF' h...
ERROR test_os/test_os.py::test_stdio - AttributeError: type object 'EOF' has ...
ERROR test_os/test_os.py::test_fs_test - AttributeError: type object 'EOF' ha...
ERROR test_os/test_os.py::test_psram_test - AttributeError: type object 'EOF'...
====== 8 failed, 1050 passed, 10 skipped, 8 errors in 2738.35s (0:45:38) =======
  [1/1] Normalize sim/citest
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	boards/sim/sim/sim/configs/citest/logs/

nothing added to commit but untracked files present (use "git add" to track)
====================================================================================

@lupyuen
Copy link
Member

lupyuen commented May 17, 2025

@Fix-Point Can you check why sim:citest is failing at ostest wdog.c:365? Here's the CI Test Log:
https://gist.github.com/lupyuen/d942290f6fd6d2783aa47d243c9e3c3c

sudo docker run \
  -it \
  ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
  /bin/bash
cd
git clone https://github.com/apache/nuttx
git clone https://github.com/Fix-Point/nuttx-apps apps --branch fix-wdog-delay
pushd nuttx ; git reset --hard HEAD ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps  ; git reset --hard HEAD ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd ~/nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/sim-01.dat
[ Wait for CI Test to fail, press Ctrl-C ]
ls -l ~/nuttx/boards/sim/sim/sim/configs/citest/logs/sim/sim
cat ~/nuttx/boards/sim/sim/sim/configs/citest/logs/sim/sim/*.log

Configuration/Tool: sim/citest
...
user_main: wdog test
wdog_test start...
wdtest_once 0 ns
...
wdtest_once 1000000 ns
dump_assert_info: Current Version: NuttX  12.9.0 e5bf4fc5c4 May 17 2025 00:34:19 sim
dump_assert_info: Assertion failed : at file: wdog.c:365 task: ostest process: ostest 0x400bc798

@Fix-Point Fix-Point force-pushed the fix-wdog-delay branch 2 times, most recently from 50810ac to a6b9082 Compare May 19, 2025 07:05
This commit updated the wdog_test to adapt to the semantic changes of
the wd_start.

Signed-off-by: ouyangxiangzhen <[email protected]>
@Fix-Point Fix-Point requested a review from cederom May 19, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants