Skip to content

Attach diagnostic for wrong arg number error #15451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Chen-Yuan-Lai
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

well explained in the issue.

What changes are included in this PR?

  1. Create a new function take_function_args_with_diag, which can accept span info and rerun DataFusionError::Diagnostic.
  2. To prevent diagnostic info loss because the error macros "flatten" the inner error to a string, diagnostic was cloned and reattached to a new error in different layers
  3. Add a new test

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions common Related to common crate functions Changes to functions implementation labels Mar 27, 2025
@Chen-Yuan-Lai Chen-Yuan-Lai marked this pull request as draft March 31, 2025 10:11
@Chen-Yuan-Lai Chen-Yuan-Lai force-pushed the attach_Diagnostic_for_wrong_arg_number_error branch from bbb8be4 to cd7d998 Compare April 14, 2025 17:08
@Chen-Yuan-Lai Chen-Yuan-Lai force-pushed the attach_Diagnostic_for_wrong_arg_number_error branch from 33be555 to edcb2a9 Compare April 23, 2025 09:51
Copy link

github-actions bot commented Jul 2, 2025

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate functions Changes to functions implementation logical-expr Logical plan and expressions sql SQL Planner Stale PR has not had any activity for some time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach Diagnostic to "wrong number of arguments" error
1 participant