-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46609: [Release][CI] Use System GTest for macos verification #46823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@github-actions crossbow submit verify-rc-source-cpp-macos-amd64 verify-rc-source-cpp-linux-ubuntu-24.04-amd64 |
Revision: a295e17 Submitted crossbow builds: ursacomputing/crossbow @ actions-a736b5ee65
|
@github-actions crossbow submit verify-rc-source-cpp-macos-amd64 verify-rc-source-cpp-linux-ubuntu-24.04-amd64 |
Revision: e2d6347 Submitted crossbow builds: ursacomputing/crossbow @ actions-d4e7beb963
|
Use GitHub syntax instead
@github-actions crossbow submit verify-rc-source-cpp-macos-amd64 verify-rc-source-cpp-linux-ubuntu-24.04-amd64 |
Revision: da3e1b0 Submitted crossbow builds: ursacomputing/crossbow @ actions-868e9b032d
|
@github-actions crossbow submit verify-rc-source--macos- |
Revision: da3e1b0 Submitted crossbow builds: ursacomputing/crossbow @ actions-01e35ef461 |
The previous failure (Gtest build) is fixed but the integration jobs seem to be failing to generate the integration data, see:
I am unsure why and I can't seem to find any related commit about integration tests apart from moving the JS integration tests to use the remote repository. @kou do you know if something has changed about the data generation that could cause this failure? |
Hmm. It seems that diff --git a/dev/archery/archery/integration/datagen.py b/dev/archery/archery/integration/datagen.py
index c8cc36ddc5..18f1d4803d 100644
--- a/dev/archery/archery/integration/datagen.py
+++ b/dev/archery/archery/integration/datagen.py
@@ -609,9 +609,9 @@ class BinaryField(PrimitiveField):
sizes = self._random_sizes(size)
- for i, nbytes in enumerate(sizes):
+ for i, np_nbytes in enumerate(sizes):
if is_valid[i]:
- values.append(random_bytes(nbytes))
+ values.append(random_bytes(int(np_nbytes)))
else:
values.append(b"") |
Ah, this may be related to Python version: Python 3.12: import numpy as np
list(enumerate(np.random.exponential(scale=4, size=10).astype(np.int32)))
# => [(0, 0), (1, 0), (2, 4), (3, 7), (4, 1), (5, 2), (6, 7), (7, 7), (8, 1), (9, 0)] Python 3.13: import numpy as np
list(enumerate(np.random.exponential(scale=4, size=10).astype(np.int32)))
# => [(0, np.int32(0)), (1, np.int32(7)), (2, np.int32(5)), (3, np.int32(1)), (4, np.int32(1)), (5, np.int32(4)), (6, np.int32(0)), (7, np.int32(4)), (8, np.int32(3)), (9, np.int32(1))] |
@github-actions crossbow submit verify-rc-source-integration-* |
Revision: a1e44fc Submitted crossbow builds: ursacomputing/crossbow @ actions-7f6847a981 |
oh! This seems to be a bug on Python 3.13.4 that is getting fixed on Python 3.13.5, see: |
@kou this should be ready for review now. |
Rationale for this change
Our system GoogleTest (installed by Homebrew) and the bundled GoogleTest are mixed and we get some CI failures.
What changes are included in this PR?
Use the system GoogleTest on our verification CI jobs for macOS.
The PR also contains a minor fix on gendata due to a small bug on a Python version.
Are these changes tested?
Yes, via archery.
Are there any user-facing changes?
No