GH-46375: [C++] Add adapters/orc to Meson configuration #46409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WillAyd
commented
May 12, 2025
| [wrap-file] | ||
| source_url = https://www.apache.org/dyn/closer.lua/orc/orc-1.9.6/orc-1.9.6.tar.gz?action=download | ||
| source_fallback_url = https://dlcdn.apache.org/orc/orc-1.9.6/orc-1.9.6.tar.gz | ||
| source_filename = orc-1.9.6.tar.gz |
There was a problem hiding this comment.
I had to intentionally limit the version of orc < 2, as in 2.0 they introduced a new externalproject called orc-format that contains just the proto files for orc. Meson wrapping a CMake configuration to call an ExternalProject that itself is not a CMake project seemed pretty fragile...
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit *meson |
|
Revision: 89b9a3f Submitted crossbow builds: ursacomputing/crossbow @ actions-eb6663e1e5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This continues building out the functionality of the Meson integration
What changes are included in this PR?
This adds the adapters/orc directory to Meson
Are these changes tested?
Yes
Are there any user-facing changes?
No