Revert "Improve coalesce and concat performance for views (#7614)"
#7623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Jun 7, 2025
| if keep_views { | ||
| self.views_buffer.extend_from_slice(array.views()); | ||
| } else { | ||
| let starting_buffer = self.completed.len() as u32; |
There was a problem hiding this comment.
I think one bug is that this starting buffer value should be calculated before extending self.completed a few lines above
Dandandan
commented
Jun 7, 2025
| if keep_views { | ||
| self.views_buffer.extend_from_slice(array.views()); | ||
| } else { | ||
| let starting_buffer = self.completed.len() as u32; |
There was a problem hiding this comment.
Hm - this seems off as we already pushed to self.completed @alamb (I only have time later today to address)
There was a problem hiding this comment.
I'll make some new tests / etc to try and cover this case
|
Let's revert it to be safe, and we can re-create a new PR with some more testing |
Dandandan
added a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jun 7, 2025
…apache#7614)" (apache#7623)" This reverts commit da461c8.
alamb
pushed a commit
that referenced
this pull request
Jun 8, 2025
#7625) … (#7614)" (#7623)" This reverts commit da461c8. This adds a test and fix for the wrong index issue. I also verified the change for DataFusion (and benchmarks show notable improvements). # Which issue does this PR close? Closes #NNN. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?
alamb
added a commit
that referenced
this pull request
Jun 9, 2025
# Which issue does this PR close? - Follow on to #7625 from @Dandandan # Rationale for this change I want to eventually remove `gc_string_view` but currently the unit tests are in terms of that function # What changes are included in this PR? Rewrite tests to be in terms of `coalesce` instead Also, 1. Add additional coverage for the issue we saw in #7623 2. Add add coverage for the case where there are data buffers in the view, but they are not referenced by any view #7625 (comment) Codecov of this module is now 100% # Are there any user-facing changes? If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7739a83.
Which issue does this PR close?
Rationale for this change
I found this errors in DataFusion (see apache/datafusion#16249 (comment)), so let's revert it and find the error.
What changes are included in this PR?
Are there any user-facing changes?