Skip to content

Rollback of compressed messages return too many credits #5574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntonRoskvist
Copy link
Contributor

When messages are compressed and get small enough to pass as regular messages, consumer credits can get thrown off balance, in particular following a rollback.

This has two effects:

  1. Consumers can get more messages "delivering" than what consumerWindowSize should allow.
  2. Over time, accumulated credits can overflow, causing negative credits and thereby marking the consumer as "busy".

I am open to rewriting the test to be faster if you have any recommendations on it, I had some trouble formulating it in a good way that would demonstrate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant