Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fortran90] Fix for #3509--TypeScript target. #3510

Merged
merged 3 commits into from
Jun 6, 2023
Merged

[fortran90] Fix for #3509--TypeScript target. #3510

merged 3 commits into from
Jun 6, 2023

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Jun 5, 2023

This PR is a fix for #3509.

This was an easy fix, thanks to the comment from @ericvergnaud here. It's just a change to the declaration for the base class. With it, we now have a grammar that is split and superClass'ed for the lexer working for 8 targets, the first of its kind.

@kaby76
Copy link
Contributor Author

kaby76 commented Jun 5, 2023

The antlr4 tool is not robust. antlr/antlr4-tools#13

@teverett
Copy link
Member

teverett commented Jun 6, 2023

@kaby76 thanks!

@teverett teverett merged commit 0337786 into antlr:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants