-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating README to refer to ANTLR 5 #9
Conversation
d29a04e
to
578e6c7
Compare
Makes sense, thank you Eric! |
That PR doesn't touch the |
Sure but he might need to rebase to an old commit, in which case we'd have to redo all this... |
README.md
Outdated
As of now, there is no collection of grammars for ANTLR 5, but we plan | ||
to grow such collection in [grammars-v5](https://github.com/antlr/grammars-v5), which is currently empty. | ||
|
||
Until we get grammars for ANTLR 5, you can take a look at [this repository](https://github.com/antlr/grammars-v4); it is a collection of grammars for ANTLR 4 without actions where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "without actions" has bothered me for a while. I don't think it is correct.
First, there are many grammars in grammars-v4 that contain both "actions" and "semantic predicates". According to the documentation:
In either case, we have a slew.
-
"actions", using Trash,
//actionBlock[not(following-sibling::QUESTION)]
.
actions.txt -
"semantic predicates", using Trash,
//actionBlock[following-sibling::QUESTION]
.
sem-preds.txt
Secondly, they are lexed identically, and parsed nearly identically.
The phrase should be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will remove the sentence
@ftomassetti please rebase on |
Yes, but I want to keep git history as clear as possible. Maybe it's out of priority for other contributors but it's important for me (I've been working on Kotlin Compiler for almost 3 years and I understand how it could be important). That's why I adhere And I didn't want to have extra commits in Now the merge is finished (force-push to dev) and other PRs can be merged using safe GitHub methods. |
8b4be0e
to
55d74cb
Compare
I know I need to re-sign the commits, but I am currently at a computer where I need to reconfigure GPG, so I will do that as soon as I can |
dc7abfb
to
8473b2d
Compare
Ok, it seems now that DCO and tests are all green |
I suggest you rebase, I had some changes on my side not yet merged. |
Signed-off-by: Federico Tomassetti <[email protected]>
Signed-off-by: Federico Tomassetti <[email protected]>
Signed-off-by: Federico Tomassetti <[email protected]> Signed-off-by: Federico Tomassetti <[email protected]>
8473b2d
to
6f2c45c
Compare
Sure, I have now rebased |
Signed-off-by: Federico Tomassetti <[email protected]>
Thank you for approving the PR! |
I took a first look at the README, renaming most references to ANTLR 4 into references to ANTLR 5.
I also tried to:
This is related to #3
Follow up: Update image to change master into main. This would be easier if we had the sources of the image.