-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor v4 -> v5 #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please fill commit message with meaningfull text. I mean first pass
doesn't explain changes, I'd use something like this:
Update version info (4 -> 5) and related things
Update contributors list
Use relative links in doc where it's possible
Fix Markdown formatting
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
Co-authored-by: Ivan Kochurkin <[email protected]>
…antlr5 into change-version-references
Signed-off-by: Eric Vergnaud <[email protected]>
I've reached a state where it compiles - no attempts to test |
…sion-references # Conflicts: # README.md
Sorry, but could you please wait for approvement from at least one member next time? It's community-driven project but not one-person-driven, isn't it? Also, please use git squashing next time to get rid of useless commits (or squash/edit them manually). Now I see a lot of non-informative commits in antlr5 history instead of one meaningful commit. I don't understand why we are rushing. |
Hey, ok to squash in the future. |
Thanks.
I don't think changing version number affects users' contributions and experience. Project was compilable before this change. |
No description provided.