Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor v4 -> v5 #4

Merged
merged 16 commits into from
Jan 17, 2024
Merged

refactor v4 -> v5 #4

merged 16 commits into from
Jan 17, 2024

Conversation

ericvergnaud
Copy link
Contributor

No description provided.

@ericvergnaud ericvergnaud requested a review from kaby76 January 17, 2024 15:24
@KvanTTT KvanTTT self-requested a review January 17, 2024 15:58
Copy link
Member

@KvanTTT KvanTTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please fill commit message with meaningfull text. I mean first pass doesn't explain changes, I'd use something like this:

Update version info (4 -> 5) and related things

Update contributors list
Use relative links in doc where it's possible
Fix Markdown formatting

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/tree-matching.md Outdated Show resolved Hide resolved
doc/tree-matching.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
runtime/Dart/README.md Outdated Show resolved Hide resolved
runtime/JavaScript/README.md Outdated Show resolved Hide resolved
@ericvergnaud ericvergnaud changed the title first pass refactor v4 -> v5 Jan 17, 2024
@ericvergnaud ericvergnaud changed the base branch from main to dev January 17, 2024 21:51
@ericvergnaud
Copy link
Contributor Author

I've reached a state where it compiles - no attempts to test
Merging so it can be used by other contributors
Partially fixes #3

…sion-references

# Conflicts:
#	README.md
@ericvergnaud ericvergnaud merged commit 30a0da7 into dev Jan 17, 2024
1 check passed
@ericvergnaud ericvergnaud deleted the change-version-references branch January 17, 2024 21:58
@KvanTTT
Copy link
Member

KvanTTT commented Jan 17, 2024

Sorry, but could you please wait for approvement from at least one member next time? It's community-driven project but not one-person-driven, isn't it?

Also, please use git squashing next time to get rid of useless commits (or squash/edit them manually). Now I see a lot of non-informative commits in antlr5 history instead of one meaningful commit.

I don't understand why we are rushing.

@ericvergnaud
Copy link
Contributor Author

Hey, ok to squash in the future.
I'm just making sure we rapidly reach a situation where people can start contributing on a viable basis, which is where we are now i.e. the project compiles.

@KvanTTT
Copy link
Member

KvanTTT commented Jan 18, 2024

Hey, ok to squash in the future.

Thanks.

I'm just making sure we rapidly reach a situation where people can start contributing on a viable basis, which is where we are now i.e. the project compiles.

I don't think changing version number affects users' contributions and experience. Project was compilable before this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants