-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(new reviewer): answer timer #18510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In the first video, the answer counts are not in a stable position on the screen. Can this be fixed? |
localized below the Count numbers to avoid losing screen space
I prefer the timer below the counts. Very minor preference. Implementer's choice My point was that It's distracting to have UI elements move in-between cards. |
In most use cases, the user either will never use the timer or always use the timer. If they have mixed deck options, and with the same parent deck, the vanishing/appearing timer calls the atention either way, and that may be even beneficial for that case, so the user notices that there is a timer. |
@BrayanDSO - I think you mean "In most use cases, the user either will never use the timer or always use the timer" (never/always, vs never/never) ? @david-allison I'm inclined to agree, I don't think most decks contain mixed note types, and I don't think most people that like the timer will only use it sometimes, and my guess at the intersection of those two guesses is pretty small and Brayan's argument it might even be a positive is somewhat persuasive. I'm inclined to go with Brayan on this one and go with it as-is Needs consensus either way though ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy (to keep the moving UI elements), could we document the decision in the code?
Never/Always. |
localized below the Count numbers to avoid losing screen space
Approach
Chronometer
to handle configuration changes properlyHow Has This Been Tested?
Emulator SDK 35:
timer.mp4
Android 15 phone (Galaxy S23):
Screen_Recording_20250613_203446_AnkiDroid.mp4
Learning (optional, can help others)
Checklist
Please, go through these checks before submitting the PR.