Expand/collapse icon rendering immediately when adding subdeck

[gayatriii0803]

Purpose / Description

Expand/collapse icon was not updating immediately after adding a subdeck

Fixes

• Fixes Expand/collapse icon not rendering immediately when adding subdeck #18278

Approach

Added oldItem.children.isEmpty() == newItem.children.isEmpty() to areContentsTheSame() in DiffUtil.ItemCallback to correctly reflect changes in child deck presence.

How Has This Been Tested?

Emulator

WhatsApp.Video.2025-05-05.at.21.51.52_ef7d4075.mp4

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [] UI Changes: You have tested your change using the Google Accessibility Scanner

[Arthur-Milchior]

Please remove the two new files. They are not needed.
Generally, it's nice if you take a look at the "files changed" on PR you open. That's the kind of surprise that occurs all of the time.

Appart from that, very good.

Note to reviewers: don't merge until the two log files are removed.

[Arthur-Milchior]

Also, I'd love your commit message to be more than a single line. You could at least reuse your "approach" from your pr description.

But more importantly, it would be to explain why we need to consider whether there are subdecks or not

[Arthur-Milchior]

I would not add this as the last element.
If you added it just after did, it would allow you to change a single line instead of two. Also, it would ensure that the things you test are in the order in which they are displayed on screen.
I'd also add a comment stating

We need to know whether there are children in order to know whether we draw the icon on the left

Actually there is still an issue

[Arthur-Milchior]

Screen_recording_20250508_052856.mp4

Actually, there is still an issue. If you create the first subdeck or if you delete the last subdeck, you'll end up with decks that are not aligned.
This is because, if there is a single subdeck anywhere in the collection, all decks are moved to the right in order to let room for the icon on the left when needed. And in order that even when the icon is not needed, the decks are aligned together

Which means that your state need to record also whether there was a subdeck somewhere in the collection

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[Arthur-Milchior]

@gayatriii0803 Eh, can you please let us know whether you plan to update?