Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(7702): add max_fill, random_fill, and use for gas estimation #991

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

andysim3d
Copy link
Collaborator

[Closes/Fixes] #979

Proposed Changes

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 39.50617% with 98 lines in your changes missing coverage. Please review.

Project coverage is 59.10%. Comparing base (2c64f9f) to head (ffafd19).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/provider/src/alloy/entry_point/mod.rs 0.00% 28 Missing ⚠️
crates/types/src/authorization.rs 27.58% 21 Missing ⚠️
crates/pool/src/server/remote/protos.rs 0.00% 18 Missing ⚠️
crates/types/src/user_operation/v0_7.rs 0.00% 13 Missing ⚠️
crates/types/src/user_operation/v0_6.rs 25.00% 12 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 2 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 2 Missing ⚠️
crates/types/src/user_operation/mod.rs 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/pool.rs 96.98% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/uo_pool.rs 92.28% <100.00%> (+0.15%) ⬆️
crates/utils/src/random.rs 100.00% <100.00%> (ø)
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% <0.00%> (ø)
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% <0.00%> (ø)
crates/types/src/user_operation/mod.rs 70.80% <75.00%> (-0.73%) ⬇️
crates/types/src/user_operation/v0_6.rs 89.30% <25.00%> (-1.82%) ⬇️
crates/types/src/user_operation/v0_7.rs 63.35% <0.00%> (-0.32%) ⬇️
crates/pool/src/server/remote/protos.rs 2.21% <0.00%> (-0.04%) ⬇️
crates/types/src/authorization.rs 44.73% <27.58%> (+44.73%) ⬆️
... and 1 more
Flag Coverage Δ
unit-tests 59.10% <39.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.60% <ø> (ø)
dev ∅ <ø> (∅)
pool 67.03% <66.66%> (+0.09%) ⬆️
provider 19.41% <0.00%> (-0.08%) ⬇️
rpc 26.43% <ø> (ø)
sim 77.04% <ø> (ø)
tasks ∅ <ø> (∅)
types 66.52% <27.27%> (-0.76%) ⬇️
utils 32.43% <100.00%> (+2.36%) ⬆️

Cargo.toml Outdated Show resolved Hide resolved
bin/rundler/Cargo.toml Outdated Show resolved Hide resolved
crates/rpc/Cargo.toml Outdated Show resolved Hide resolved
@dancoombs
Copy link
Collaborator

I think you still need to address #979 (comment)

@andysim3d andysim3d merged commit a997527 into main Feb 4, 2025
11 checks passed
@andysim3d andysim3d deleted the andy/7702-fix branch February 4, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants