Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7702 Auth bugs #979

Open
dancoombs opened this issue Jan 29, 2025 · 1 comment
Open

7702 Auth bugs #979

dancoombs opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dancoombs
Copy link
Collaborator

Describe the bug
Collecting a list of places where 7702 auth seems to have bugs

Auth tuple isn't serialized to proto:

authorization_tuple: None,

Auth list doesn't impact the input of txn_request and thus isn't included in da calculation

txn_request = txn_request.with_authorization_list(vec![authorization.into()]);

txn_req = txn_req.with_authorization_list(vec![authorization_tuple.into()]);

Auth is not max/random filled for DA calculations. (Max fill isn't used for DA - but we should fix, random fill is). These should be filled with max and random signature values.

authorization_tuple: None,

authorization_tuple: None,

..Default::default()

@dancoombs dancoombs added the bug Something isn't working label Jan 29, 2025
@dancoombs
Copy link
Collaborator Author

Missing auth costs in PVG calc

self.static_pre_verification_gas(chain_spec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants