AG-12204 - Next step in ESLlint v9 upgrade #3359
Conversation
alantreadway
changed the title
alantreadway
force-pushed
the
ag-12204/complete-eslint-v9-upgrade
branch
from
b83572c to
987959c
Compare
| @@ -52,8 +52,6 @@ export const sonarjsConfig = [ | |||
|
|
|||
| // For review - new for eslint 9. | |||
| 'sonarjs/no-redeclare': 1, | |||
| 'sonarjs/public-static-readonly': 1, | |||
There was a problem hiding this comment.
Note: Removing these entries activates the rules at error level.
| title?: string; | ||
| symbol?: LegendSymbolOptions; | ||
| data?: TooltipContentDataRow[]; | ||
| rawHtmlString?: string; | ||
| } |
There was a problem hiding this comment.
This is one or the other. Might be better to represent like this:-
| title?: string; | |
| symbol?: LegendSymbolOptions; | |
| data?: TooltipContentDataRow[]; | |
| rawHtmlString?: string; | |
| } | |
| title?: string; | |
| symbol?: LegendSymbolOptions; | |
| data?: TooltipContentDataRow[]; | |
| } | { | |
| rawHtmlString: string; | |
| } |
There was a problem hiding this comment.
I've tried applying this - but the simplest thing to do is add a type discriminator field, as 'rawHtmlString' in content isn't enough of a hint to the TS compiler that on the negative control flow that the inferred typing of content is a single union member type.
9e3aeac is the smallest additional change encoding use of a type union for TooltipContent.
| let i = 0; | ||
| let estimatedWidth = 0; | ||
| let lastSpaceIndex = 0; | ||
| while (i < line.length) { |
There was a problem hiding this comment.
Wondering, what was the warning here about?
There was a problem hiding this comment.
Mutating the iteratee in a for-loop
| title?: string; | ||
| symbol?: LegendSymbolOptions; | ||
| data?: TooltipContentDataRow[]; | ||
| rawHtmlString?: string; | ||
| } |
There was a problem hiding this comment.
I've tried applying this - but the simplest thing to do is add a type discriminator field, as 'rawHtmlString' in content isn't enough of a hint to the TS compiler that on the negative control flow that the inferred typing of content is a single union member type.
9e3aeac is the smallest additional change encoding use of a type union for TooltipContent.
https://ag-grid.atlassian.net/browse/AG-12204