Allow for partial application of the message context #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows, with a backward compatible modification, to let the developers partially apply a context to a message.
This is very useful for instance when extending the messages provided by
ember-validations
to reusemessageFor
to do the extension/replacement instead of doing a.replace(...)
manually, which might break eventually...Down to earth example:
wrongDateFormat
("{description} must be in the format of {format}")format
used wasL
(using the moment terminology)L
("MM/DD/YYYY" in en_US and "JJ/MM/AAAA" in fr_FR) in the messageWhat do you think?