feat(addon/components/paper-item): converts to a glimmer component. #1304
+190
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
6d432ac to
9ff786f
Compare
20 tasks
matthewhartstonge
force-pushed
the
feature/glimmer-paper-form
branch
from
ce53c9b to
e1eda8e
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
9ff786f to
e185cab
Compare
20 tasks
|
Failing tests fixed by #1305! |
matthewhartstonge
force-pushed
the
feature/glimmer-paper-form
branch
from
e1eda8e to
3409186
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
1ad715a to
1e72457
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-form
branch
from
3409186 to
d5cce06
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
1e72457 to
9f3982b
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-form
branch
from
d5cce06 to
34f1129
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
5b35c04 to
3496e2a
Compare
matthewhartstonge
changed the base branch from
feature/glimmer-paper-form
to
feature/glimmer-paper-checkbox
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
3496e2a to
6061018
Compare
… simplifies bitwise operation for developers to an or.
… to support classic and glimmer components.
…didInsertNode`, `willDestroyNode`.
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
a765f74 to
896adac
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
6061018 to
d8e8c1e
Compare
|
Some tests with 'continue-on-error: true' have failed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: two tests fail:
Integration | Component | paper item: single action checkboxes should react to checkbox clicksIntegration | Component | paper item: Item checkbox with secondary action and no primary action is toggled by checkbox clickThis appears due to to
clickonly bubbling once under classic components, whereas the proxy call is being made under the glimmer parent, then the click handler is being called on the checkbox classic component.Hoping this will come out in the wash once paper-checkbox is migrated to glimmer.