use .slice when .toArray is not present

[artemgurzhii]

No description provided.

[netlify]

✅ Deploy Preview for ember-drag-drop ready!

Name	Link
🔨 Latest commit	ad1c4de
🔍 Latest deploy log	https://app.netlify.com/sites/ember-drag-drop/deploys/66def68bc6b2c10008892c41
😎 Deploy Preview	https://deploy-preview-10--ember-drag-drop.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[bvedad]

Any progress on this one? I am encountering this issue as I wanted to perform Ember upgrade.

[SergeAstapov]

@artemgurzhii thank you! Do you think you could add a test case to ensure this is working as expected now and in the future?

[artemgurzhii]

@SergeAstapov sure, I can try to. do you have ideas on how you would expect it to be tested?

[artemgurzhii]

@bvedad I have added

<script>
  // TODO: remove once https://github.com/adopted-ember-addons/ember-drag-drop/pull/10 is merged & released
  Array.prototype.toArray = function() {
    return this.slice();
  };
</script>

to app/index.html and tests/index.html files for now.

Or you can also try to install a forked version, ie replace "ember-drag-drop": "^1.0.0", with "ember-drag-drop": "uplisting/ember-drag-drop#main", until a new version is released. I have used first option, so that I don't miss if any new version of ember-drag-drop is released

[SergeAstapov]

@SergeAstapov sure, I can try to. do you have ideas on how you would expect it to be tested?

as far as I can see, it's a problem with @sortableObjectList argument which could be native Array or could be an EmberArray.

as far as I can see, this PR makes it possible to pass to @sortableObjectList argument native Array which does not have .toArray() method.

We have tests in https://github.com/adopted-ember-addons/ember-drag-drop/blob/main/test-app/tests/integration/components/sortable-objects-test.js#L10 that all verify it works with pojoData array which is EmberArray.

Hence, could you please add a test case in https://github.com/adopted-ember-addons/ember-drag-drop/blob/main/test-app/tests/integration/components/sortable-objects-test.js#L10 to test <SortableObjects> component rendering with @sortableObjectList argument like

let nativePojoData = [
  { id: 1, title: 'Number 1' },
  { id: 2, title: 'Number 2' },
  { id: 3, title: 'Number 3' },
  { id: 4, title: 'Number 4' },
];

[artemgurzhii]

@SergeAstapov I'm not sure that it would work, as it requires environment config change like so:

EmberENV: {
  EXTEND_PROTOTYPES: false,
},

as if not - Ember would globally define their custom array methods on the global array prototype, which means that all arrays(Ember.A() and [] as well) will have access to those methods.

[SergeAstapov]

@artemgurzhii I would say this what we gonna do anyways to ensure support of newer versions of Ember.js where prototype extensions being deprecated and removed

[artemgurzhii]

@SergeAstapov should we then disable prototype extensions to test that functionality explicitly?

[SergeAstapov]

@artemgurzhii yes, I believe so - that way we can explicitly pass both native Array and EmberArray as arguments