Feature/379 update blueprint #380
Conversation
Gorzas
force-pushed
the
feature/379-update-blueprint
branch
2 times, most recently
from
5f14c3c to
49dd10d
Compare
package.json
Outdated
| @@ -68,5 +68,8 @@ | |||
| }, | |||
| "ember-addon": { | |||
| "configPath": "tests/dummy/config" | |||
| }, | |||
There was a problem hiding this comment.
I don't think we should add the edition in the package.json until we update the version of ember-cli (we're currently on ember-cli 3.3)
There was a problem hiding this comment.
FYI I've started trying to upgrade ember-cli in #385
There was a problem hiding this comment.
@Gorzas if you pull the latest changes from master you should be able to remove these changes now
|
|
||
| export default MF.Fragment.extend({ | ||
| export default class <%= classifiedModuleName %> extends Fragment { | ||
| <%= attrs %> |
There was a problem hiding this comment.
Could we remove the space here because having it indented results in the first attr being indented too far?
| <%= attrs %> | |
| <%= attrs %> |
There was a problem hiding this comment.
@patocallaghan doing some tests with the generator, I've found that the result with attributes isn't valid. Look what happens when I type ember g fragment foo bar:string:
import { attr } from '@ember-data/model';
import Fragment from 'ember-data-model-fragments/fragment';
export default class Foo extends Fragment {
bar: attr('string')
}
So I'm going to fix that too.
package.json
Outdated
| @@ -68,5 +68,8 @@ | |||
| }, | |||
| "ember-addon": { | |||
| "configPath": "tests/dummy/config" | |||
| }, | |||
There was a problem hiding this comment.
@Gorzas if you pull the latest changes from master you should be able to remove these changes now
Gorzas
force-pushed
the
feature/379-update-blueprint
branch
from
49dd10d to
23326ff
Compare
No description provided.