Skip to content

Optimizing XPath performance using XSLT extensions #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Honesty-of-the-Cavernous-Tissue
Copy link

@Honesty-of-the-Cavernous-Tissue Honesty-of-the-Cavernous-Tissue commented Mar 18, 2025

The

def prune_unwanted_nodes(
function takes a lot of time when processing large amounts of text, i used a common-crawl shard to test and used md5sum to verify the consistency of the changes.

@adbar
Copy link
Owner

adbar commented Mar 31, 2025

Hi @Honesty-of-the-Cavernous-Tissue, while your idea is good in general order matters for these XPath expressions.

I advise against it, you would have to be sure to pass the tests and not to degrade the evaluation for your PR to be accepted.

@adbar
Copy link
Owner

adbar commented Apr 3, 2025

@Honesty-of-the-Cavernous-Tissue You'd still need to fix type hinting for Python 3.13 and test of there is a regression on the benchmark (see tests Readme).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants