Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardcoded namespace and add support for multiple listener pods #3869

Closed
wants to merge 2 commits into from

Conversation

@fed-sv fed-sv requested review from mumoshu, toast-gear, rentziass and a team as code owners January 7, 2025 01:01
@fed-sv fed-sv changed the title fix: hardcoded namespace fix: hardcoded namespace and add support for multiple listener pods Jan 7, 2025
@nikola-jokic
Copy link
Collaborator

Hey @fed-sv

Can you please help me understand why is this change needed? There is only one listener per autoscaling runner set. We deployed it on the desired namespace, and install one scale set to that namespace.

@fed-sv
Copy link
Author

fed-sv commented Jan 23, 2025

hi @nikola-jokic , there are two changes, the first one it's replacing the hardcoded namespace arc-systems with the user entered namespace ${{inputs.arc-controller-namespace}}.
The other change, it's so that this task works when you have multiple listeners. For example in our workplace we have 5 different listeners. Not sure why this task was assuming only one listener?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants