Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename Deprecated to Inactive #310

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

rotimi-best
Copy link
Contributor

@rotimi-best rotimi-best commented Mar 7, 2024

Based on the conversations here.

Fixes: #301

In order to implement that issue, I need to first rename Deprecated to Inactive before I can implement the tags properly.

This is because the code for fetching the README looks at the code merged into main and if this change isn't in main first we can't properly test it due to the fact I will be searching for the word Inactive while on main we still have Deprecated.

Once this PR is merged in, I will go ahead to implement adding the Inactive and Archived tag on each project depending on what's in the README

Copy link

codesandbox bot commented Mar 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@acekyd
Copy link
Owner

acekyd commented Mar 7, 2024

Understood. Thinking about that - the fetching the link from the main branch remotely may no longer be necessary. That was important because we had the code and the readme in different branches, now that they are together in the same branch - see if you can refactor the fetch to use the local readme file it has in the file path 🤔 @rotimi-best

@acekyd
Copy link
Owner

acekyd commented Mar 7, 2024

And implement it all together in this PR.

@acekyd
Copy link
Owner

acekyd commented Mar 8, 2024

Seen this? @rotimi-best

@rotimi-best
Copy link
Contributor Author

@acekyd oh I missed that notification.

Hmm interesting. I honestly have no idea how we would fetch it from the local README.

Ideally we should have the data in JSON that is properly structured for mapping and rendering.

What do you think?

@acekyd
Copy link
Owner

acekyd commented Mar 8, 2024

It's alright... I'll make the update and let you know. From there you can create a new branch off main for the new PR.

@acekyd acekyd merged commit 95d5134 into acekyd:dev Mar 8, 2024
4 checks passed
@rotimi-best
Copy link
Contributor Author

Sounds good, thanks 👍🏾.

There is this change to get the actual status of each repo using the Github API suggested by @kaf-lamed-beyt #301 (comment)

I am currently implementing that one using the current code that calls parses the README.

Should I continue working on it using the README fetch or wait until you make the change to main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants