Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue #1 : Cache the container to avoid object creation #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Address issue #1 : Cache the container to avoid object creation #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/Facade.CosmosDbSql/Connectors/AzureCosmosDbV3/AzureCosmosDbV3Connector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ public class AzureCosmosDbV3Connector : IAzureCosmosDbV3Connector, IDisposable
{
private readonly CosmosClient _client;
private readonly JsonSerializerSettings _jsonSerializerSettings;

private readonly Dictionary<(string, string), Container> _containerByDatabaseIdAndContainerId;
public AzureCosmosDbV3Connector(string endpoint, string key)
{
_containerByDatabaseIdAndContainerId = new Dictionary<(string, string), Container>();
_jsonSerializerSettings = new JsonSerializerSettings()
{
DateParseHandling = DateParseHandling.DateTimeOffset,
Expand Down Expand Up @@ -73,21 +74,21 @@ public async Task<bool> CreateCollectionIfNotExistsAsync(

public async Task<bool> CreateItemAsync<T>(string databaseId, string collectionId, DocumentBase<T> item)
{
var container = _client.GetContainer(databaseId, collectionId);
var container = GetContainer(databaseId, collectionId);
var response = await container.CreateItemAsync<dynamic>(item);
return IsResponseValid(response.StatusCode);
}

public async Task<bool> UpdateItemAsync<T>(string databaseId, string collectionId, DocumentBase<T> item)
{
var container = _client.GetContainer(databaseId, collectionId);
var container = GetContainer(databaseId, collectionId);
var response = await container.ReplaceItemAsync<dynamic>(item, item.Id);
return IsResponseValid(response.StatusCode);
}

public async Task<bool> UpsertItemAsync<T>(string databaseId, string collectionId, DocumentBase<T> item)
{
var container = _client.GetContainer(databaseId, collectionId);
var container = GetContainer(databaseId, collectionId);
var response = await container.UpsertItemAsync<dynamic>(item);
return IsResponseValid(response.StatusCode);
}
Expand All @@ -99,7 +100,7 @@ public async Task<bool> DeleteItemAsync<T>(string databaseId, string collectionI
throw new ArgumentNullException(nameof(partitionKey));
}

var container = _client.GetContainer(databaseId, collectionId);
var container = GetContainer(databaseId, collectionId);
var response = await container.DeleteItemAsync<T>(id, new PartitionKey(partitionKey), null, default(CancellationToken));
return IsResponseValid(response.StatusCode);
}
Expand All @@ -111,7 +112,7 @@ public async Task<List<T>> SearchDocumentsAsync<T>(
Dictionary<string, object> parameters = null)
{
var queryRequestOptions = GetQueryRequestOptions();
var container = _client.GetContainer(databaseId, collectionId);
var container = GetContainer(databaseId, collectionId);
var queryDefinition = GetQueryDefinition(query, parameters);
var feedIterator = container.GetItemQueryStreamIterator(queryDefinition, null, queryRequestOptions);

Expand Down Expand Up @@ -162,7 +163,7 @@ public async Task<bool> DeleteCollectionIfExistsAsync(string databaseId, string
return true;
}

var container = _client.GetContainer(databaseId, collectionId);
var container = GetContainer(databaseId, collectionId);
var response = await container.DeleteContainerAsync();
return IsResponseValid(response.StatusCode);
}
Expand All @@ -172,6 +173,17 @@ public void Dispose()
_client?.Dispose();
}

private Container GetContainer(string databaseId, string containerId)
{
if (!_containerByDatabaseIdAndContainerId.TryGetValue((databaseId, containerId), out var container))
{
container = _client.GetContainer(databaseId, containerId);
_containerByDatabaseIdAndContainerId.Add((databaseId, containerId), container);
}

return container;
}

private async Task<bool> IsDatabaseExist(string databaseId)
{
var iterator = _client.GetDatabaseQueryIterator<DatabaseProperties>();
Expand Down