fix(v2-sdk): Use type-based undefined check for kLast #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add a unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in the V2 SDK where
kLast—which can beBigintishorundefined—is checked using!!kLast. This causes issues whenkLast = 0, as!!kLastevaluates tofalse, incorrectly triggering an invariant error. Since there is already existing logic for handlingkLast = 0, the proper check should ensurekLastis notundefined.How Has This Been Tested?
Manual Testing: Verified that when kLast = 0, no error is thrown.
Unit Tests: Existing unit tests were run to confirm no regressions.
Are there any breaking changes?
No, this is not a breaking change. It only adjusts the check to correctly handle 0 as a valid value for
kLast.