Skip to content

skip filter class checker #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

khaledhatahet
Copy link
Contributor

No description provided.

@Tucker-Eric Tucker-Eric self-assigned this Apr 10, 2025
@Tucker-Eric Tucker-Eric self-requested a review April 10, 2025 17:10
@Tucker-Eric Tucker-Eric merged commit 5528605 into Tucker-Eric:master Apr 10, 2025
8 checks passed
@simba77
Copy link

simba77 commented Apr 11, 2025

This PR breaks the functionality of dynamic filters.
For example:

User::filter($request->all(), BasicUserFilter::class)->get();

Because in scopeFilter, the $filter variable is not null in this case, the filtering is not performed.

@Tucker-Eric
Copy link
Owner

@simba77 oh shoot! You're correct. Fix coming in shortly.

Tucker-Eric added a commit that referenced this pull request Apr 11, 2025
Tucker-Eric added a commit that referenced this pull request Apr 11, 2025
@Tucker-Eric
Copy link
Owner

@simba77 updated and tagged with 3.5.2

Thanks for catching this! Apologies if it caused any issues on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants