Add toolbar to configure 3D viewer #347
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskino
changed the title
Closed
|
Unit tests are missing... |
These are workarounds to be able to configure the volume render
|
The
|
|
@lauramurgatroyd showed me how to use the tool bar and it worked really well for this shell dataset from https://doi.org/10.5281/zenodo.6983008 |
DanicaSTFC
requested changes
Dec 9, 2024
| @@ -37,6 +37,13 @@ def __init__(self, callback): | |||
| #self.AddObserver('RightButtonPressEvent', self.OnRightMousePress, -0.5) | |||
| #self.AddObserver('RightButtonReleaseEvent', self.OnRightMouseRelease, -0.5) | |||
|
|
|||
| self._volume_render_pars = { | |||
There was a problem hiding this comment.
The dialogs in the toolbar did not inherit the dark theme correctly. Probably this is due to not setting the parent of the dialog.
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes from https://github.com/Dagonite/CILViewer/tree/viewer_toolbar into current master
Tested with vtk9 and vtk8
supersedes #337
closes #331
The
FormDialogfor Volume render settings still is missing the following properties:QLabelfor aQDoubleSpinBoxUISliderWidget to have a QDoubleSpinBox attached eqt#125 (this has been closed by #168)sliderDownin the connection to the signalvalueChangedin the slot otherwise the volume render gets triggered too often.Currently a workaround is in place by setting 2 parameters from CLI for the
cilviewerhttps://github.com/vais-ral/CILViewer/blob/9287248ccf12f2a8e1e549d9637770aca01ce2e0/Wrappers/Python/ccpi/viewer/standalone_viewer.py#L168-L169
scale_factorcontrols how many (?) steps there are in the slider, default is 100. SeeUISliderWidgetmax_opacitycontrols the maximum opacity of the volume render opacity transfer function.