ProjectionOperator Bug Fix (Issue #1990) #2065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not case-sensitive. Added case sensitivity and unit tests for ProjectionOperator inputs. Updated environment .yml files and env creation script to include new unittest-parametrize library used in tests. Updated developer guide to include example of parametrized test usage. Added name to NOTICE.txt.
formatting Signed-off-by: M-A-Demir <[email protected]>
|
PS: In CIL/scripts/create_local_env_for_cil_development.sh, I couldn't install the pip module (unittest-parametrize) directly with the 'conda create' command , so I have changed it to use the requirements_test.yml file if $test_deps != 0. I tried an alternative, which is to have a separate list of pip dependencies, use conda create, then activate the conda environment and perform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update in response to issue #1990: ProjectionOperator device input is not case-sensitive. Added case sensitivity and unit tests for ProjectionOperator inputs. Updated environment .yml files and env creation script to include new unittest-parametrize library used in tests. Updated developer guide to include example of parametrized test usage. Added name to NOTICE.txt.
Issue: #1990
Example Usage
ProjectionOperator(ig, ag, device="GPU")device name passed is now case insensitive
❤️ Thanks for your contribution!