-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-projection geometry cone3D_souv #2039
Draft
gfardell
wants to merge
17
commits into
TomographicImaging:master
Choose a base branch
from
gfardell:non_standard_geometry_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Per-projection geometry cone3D_souv #2039
gfardell
wants to merge
17
commits into
TomographicImaging:master
from
gfardell:non_standard_geometry_v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a new AcquisitionGeometry called CONE_SOUV = 'cone_souv'. It is impossible to set_angles on this new geometry.
…metry of the first projection is used.
…e position, ii) the imager centre, iii) the imager x-direction, and iv) the imager y-direction for each projection.
…c strings and ag souv aware default behaviour.
gfardell
changed the title
Non standard geometry v2
Per-projection geometry cone3D_souv
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is adding per-projection geometry.
Building on @effepivi's work in #1850
Wrappers/Python/cil/framework/acquisition_geometry.py
Wrappers/Python/cil/framework/labels.py
Wrappers/Python/cil/plugins/astra/utilities/convert_geometry_to_astra_vec_3D.py
Wrappers/Python/cil/utilities/display.py
Testing you performed
Related issues/links
closes #1848
closes #1849
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.
--->