Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-projection geometry cone3D_souv #2039

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

gfardell
Copy link
Member

@gfardell gfardell commented Jan 15, 2025

Changes

This is adding per-projection geometry.

Building on @effepivi's work in #1850

Wrappers/Python/cil/framework/acquisition_geometry.py

  1. Adds a cone3D_souv acquisition data type
  2. Adds factory method to create datatype
  3. Updates some behaviour of acquisition geometry members/methods to account for it
  4. Updates to docstrings of each AcquisitionGeometry factory for consistency.

Wrappers/Python/cil/framework/labels.py

  1. Adds cone_souv to the AcquisitionType labels

Wrappers/Python/cil/plugins/astra/utilities/convert_geometry_to_astra_vec_3D.py

  1. Updates to set up astra geometry from cone souv

Wrappers/Python/cil/utilities/display.py

  1. Added new display method for souv type.

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

closes #1848
closes #1849

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

--->

@gfardell gfardell changed the title Non standard geometry v2 Per-projection geometry cone3D_souv Jan 15, 2025
@gfardell gfardell mentioned this pull request Jan 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the Astra backend to reconstruct per-projection geometries set the cone-beam geometry to per-projection
2 participants