Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LADMM documentation #2015

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve LADMM documentation #2015

wants to merge 4 commits into from

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Dec 12, 2024 •
edited
Loading

Changes

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

Closes #1948

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
    [ ] I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff linked an issue Dec 12, 2024 that may be closed by this pull request
LADMM documentation rendering #1948
Open
@MargaretDuff MargaretDuff self-assigned this Dec 12, 2024
@MargaretDuff
Copy link
Member Author

image
image

@MargaretDuff MargaretDuff marked this pull request as ready for review December 12, 2024 13:42
lauramurgatroyd
lauramurgatroyd requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should say the iteration maths is for k>=1?

Looks great otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramurgatroyd lauramurgatroyd lauramurgatroyd approved these changes

@jakobsj jakobsj Awaiting requested review from jakobsj

At least 2 approving reviews are required to merge this pull request.

Assignees

@MargaretDuff MargaretDuff

Labels
documentation Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LADMM documentation rendering
2 participants
@MargaretDuff @lauramurgatroyd