Skip to content

gui: CTS Viewer show/hide subtree #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2025

Conversation

LucasYuki
Copy link
Contributor

Closes #7388.

Adds the feature to hide/show subtrees in CTS Viewer by right-clicking on a buffer.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

github-actions bot commented Jun 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

LucasYuki added 4 commits June 3, 2025 19:38

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Lucas Yuki Imamura <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Lucas Yuki Imamura <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Lucas Yuki Imamura <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Lucas Yuki Imamura <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

github-actions bot commented Jun 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

@LucasYuki LucasYuki marked this pull request as ready for review June 4, 2025 17:09

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

github-actions bot commented Jun 4, 2025

clang-tidy review says "All clean, LGTM! 👍"

@arthurjolo
Copy link
Contributor

arthurjolo commented Jun 9, 2025

I tested this PR with some designs that are hard to look at the macros trees and it was really helpful. On a user side I think this PR is Ok.

@maliberty
Copy link
Member

When you hide a subtree it doesn't seem to adjust the drawing of the tree on the layout, eg
image

@maliberty
Copy link
Member

If you hide a subtree, eg
image

and then hide a higher node, eg
image

and the unhide the higher node you get the full tree
image

it appears to unhide all the lower nodes as well. Is this intended?

Copy link
Member

@maliberty maliberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments to be addressed in follow PRs

@maliberty maliberty enabled auto-merge June 9, 2025 19:10
@maliberty maliberty merged commit c760674 into The-OpenROAD-Project:master Jun 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In clock tree view add choice for macro / std cell display
3 participants