drt: via coordinates #7326
drt: via coordinates #7326
Conversation
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Bernardo Borges Sandoval <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Co-authored-by: Osama Hammad <[email protected]> Signed-off-by: Bernardo Borges Sandoval <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::vector<std::unique_ptr<frAccessPoint>>& aps, | ||
| std::set<std::pair<Point, frLayerNum>>& apset, | ||
| frInstTerm* inst_term, | ||
| const frAccessPointEnum lower_type, |
There was a problem hiding this comment.
warning: parameter 'lower_type' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const frAccessPointEnum lower_type, | |
| frAccessPointEnum lower_type, |
| std::set<std::pair<Point, frLayerNum>>& apset, | ||
| frInstTerm* inst_term, | ||
| const frAccessPointEnum lower_type, | ||
| const frAccessPointEnum upper_type); |
There was a problem hiding this comment.
warning: parameter 'upper_type' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const frAccessPointEnum upper_type); | |
| frAccessPointEnum upper_type); |
| const gtl::rectangle_data<frCoord>& rect, | ||
| int offset = 0); | ||
|
|
||
| bool OnlyAllowOnGridAccess(const frLayerNum layer_num, |
There was a problem hiding this comment.
warning: parameter 'layer_num' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| bool OnlyAllowOnGridAccess(const frLayerNum layer_num, | |
| bool OnlyAllowOnGridAccess(frLayerNum layer_num, |
| int offset = 0); | ||
|
|
||
| bool OnlyAllowOnGridAccess(const frLayerNum layer_num, | ||
| const bool is_macro_cell_pin); |
There was a problem hiding this comment.
warning: parameter 'is_macro_cell_pin' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const bool is_macro_cell_pin); | |
| bool is_macro_cell_pin); |
| rect, | ||
| !is_layer1_horz, | ||
| offset); | ||
| genAccessCoordCosted(cost, |
There was a problem hiding this comment.
warning: 4th argument 'layer_num' (passed to 'base_layer_num') looks like it might be swapped with the 5th, 'second_layer_num' (passed to 'layer_num') [readability-suspicious-call-argument]
genAccessCoordCosted(cost,
^Additional context
src/drt/src/pa/FlexPA_acc_point.cpp:153: in the call to 'genAccessCoordCosted', declared here
void FlexPA::genAccessCoordCosted(
^
Supports #7153.
Branched from #7194.
Creates the
createViaSpecificAccessPoints()which inputs the common access coordinates of a pin and creates all via specific access points.