-
Notifications
You must be signed in to change notification settings - Fork 671
Cts add user clock buffer prefix for list inferring #7231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
arthurjolo
wants to merge
5
commits into
The-OpenROAD-Project:master
Choose a base branch
from
arthurjolo:cts_add_user_clock_buffer_prefix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e72982b
add support for inferring beffer list based on user clock buffer prefix
arthurjolo 25cbaf4
add user command -buf_list_prefix to declare the prefix for inferring…
arthurjolo ecb1cb3
fix typo
arthurjolo 285a978
Merge branch 'master' into cts_add_user_clock_buffer_prefix
arthurjolo 4f5f793
prioritize cells that are marked as clock buffers
arthurjolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -667,7 +667,30 @@ void TritonCTS::inferBufferList(std::vector<std::string>& buffers) | |||||
} | ||||||
delete lib_iter; | ||||||
|
||||||
// second, look for all buffers with name CLKBUF or clkbuf | ||||||
// second, look for buffers with name especified by the user | ||||||
if (options_->getBufferListPrefix() != "") { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Suggested change
Additional context/usr/include/c++/11/bits/basic_string.h:1022: method 'basic_string'::empty() defined here empty() const _GLIBCXX_NOEXCEPT
^ |
||||||
sta::PatternMatch patternClkBuf(options_->getBufferListPrefix().c_str(), | ||||||
/* is_regexp */ true, | ||||||
/* nocase */ true, | ||||||
/* Tcl_interp* */ nullptr); | ||||||
sta::LibertyLibraryIterator* lib_iter = network_->libertyLibraryIterator(); | ||||||
while (lib_iter->hasNext()) { | ||||||
sta::LibertyLibrary* lib = lib_iter->next(); | ||||||
if (options_->isCtsLibrarySet() | ||||||
&& strcmp(lib->name(), options_->getCtsLibrary()) != 0) { | ||||||
continue; | ||||||
} | ||||||
for (sta::LibertyCell* buffer : | ||||||
lib->findLibertyCellsMatching(&patternClkBuf)) { | ||||||
if (buffer->isBuffer() && isClockCellCandidate(buffer)) { | ||||||
selected_buffers.emplace_back(buffer); | ||||||
} | ||||||
} | ||||||
} | ||||||
delete lib_iter; | ||||||
} | ||||||
|
||||||
// third, look for all buffers with name CLKBUF or clkbuf | ||||||
if (selected_buffers.empty()) { | ||||||
sta::PatternMatch patternClkBuf(".*CLKBUF.*", | ||||||
/* is_regexp */ true, | ||||||
|
@@ -690,7 +713,7 @@ void TritonCTS::inferBufferList(std::vector<std::string>& buffers) | |||||
delete lib_iter; | ||||||
} | ||||||
|
||||||
// third, look for all buffers with name BUF or buf | ||||||
// fourth, look for all buffers with name BUF or buf | ||||||
if (selected_buffers.empty()) { | ||||||
sta::PatternMatch patternBuf(".*BUF.*", | ||||||
/* is_regexp */ true, | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: redundant string initialization [readability-redundant-string-init]