mpl: hard macro partitioning #7198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: João Mai <[email protected]>
Signed-off-by: João Mai <[email protected]>
Signed-off-by: João Mai <[email protected]>
|
Please add more description of this new approach. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: João Mai <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
AcKoucher
suggested changes
Apr 23, 2025
| odb::dbInst* inst = iterm->getInst(); | ||
| odb::dbMaster* master = inst->getMaster(); | ||
|
|
||
| if (master->isPad() || master->isCover() || master->isEndCap()) { |
There was a problem hiding this comment.
This should check for isIgnoredInst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was motivated by issue #6717 and aims to move the responsibility of partitioning hard macros from PAR to MPL. This hopefully makes MPL results more stable and predictable by relying less on PAR results.
The new approach still leverages PAR to split standard cells in a pair of balanced clusters, but hard macros are now assigned to a cluster based on their connectivity to the standard cell clusters.
Connectivity here is the number of non-supply nets from a cluster that a hard macro is connected to.