refactor: 🔨 Refactor considering Dart 3 support #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahil-Simform
requested changes
May 16, 2025
|
|
||
| /// To Provide padding to the action widget | ||
| /// | ||
| /// Defaults to const EdgeInsets.symmetric(horizontal: 15,vertical: 4,) |
There was a problem hiding this comment.
Can you please remove the comma?
|
|
||
| /// To Provide a text for action | ||
| /// | ||
| /// If type is provided then it will take type name |
There was a problem hiding this comment.
Revise the documentation for this property to ensure clarity.
|
|
||
| /// To Provide a onTap for action | ||
| /// | ||
| /// If type is provided then it will take type's OnTap |
Comment on lines
71
to
74
| /// This must be set if using baseline alignment. There is no default because there is no | ||
| /// way for the framework to know the correct baseline _a priori_. | ||
| /// This must be set if using baseline alignment. There is no default | ||
| /// because there is no way for the framework to know the correct baseline | ||
| /// _a priori_. | ||
| final TextBaseline? textBaseline; |
lib/src/showcase/showcase.dart
Outdated
Comment on lines
56
to
59
| /// - `titleAlignment`: Alignment of the title text within the tooltip | ||
| /// (defaults to start). | ||
| /// - `descriptionAlignment`: Alignment of the description text within | ||
| /// the tooltip (defaults to start). |
There was a problem hiding this comment.
Default values are wrong
lib/src/showcase/showcase.dart
Outdated
Comment on lines
135
to
139
| /// **Assertions:** | ||
| /// | ||
| /// - `overlayOpacity` must be between 0.0 and 1.0. | ||
| /// - `onTargetClick` and `disposeOnTap` must be used together (one cannot | ||
| /// exist without the other). |
| ), | ||
| Theme.of(context) | ||
| .textTheme | ||
| .titleSmall! |
There was a problem hiding this comment.
remove force unwrap
aditya-css
force-pushed
the
feature/dart_3_support
branch
from
3025c0a to
d45c173
Compare
Sahil-Simform
approved these changes
May 16, 2025
aditya-css
force-pushed
the
feature/dart_3_support
branch
from
a145d19 to
d45c173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added more class level documentation comments and upgraded minimum dart sdk support to version 3. Made code changes to utilise Dart 3 features.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?