Skip to content

Add more keys concerned with lsa ppl protection #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

swachchhanda000
Copy link
Contributor

@swachchhanda000 swachchhanda000 commented May 1, 2025

Summary of the Pull Request

Add more keys concerned with lsa ppl protection

Changelog

update: LSA PPL Protection Disabled Via Reg.EXE - Add more keys regarding LSA PPL

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels May 1, 2025
Comment on lines +28 to +29
- 'd '
- 'v '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep to / ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because "-" can be also used instead of /

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what the |windash modifier is for. --> please add them back and use |windash

@nasbench nasbench requested a review from phantinuss May 20, 2025 21:04
@nasbench nasbench added 2nd Review Needed PR need a second approval and removed Ready to Merge labels May 20, 2025
Comment on lines +28 to +29
- 'd '
- 'v '
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what the |windash modifier is for. --> please add them back and use |windash

Comment on lines +36 to +39
filter:
CommandLine|contains:
- "01"
- "02"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is filtered here? Can you give an example? (Is it a main or optional filter?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When modifying the registry using the reg command, you can pass a value using either of the following formats:

/d 0 /d 00000000

For example:

The intention of rule is to catch this commandline

reg add "HKLM\SOFTWARE\Policies\Microsoft\Windows\System" /v "RunAsPPL" /t REG_DWORD /d "0"

But, This means the rule will be triggered if the value is set like this:

reg add "HKLM\SOFTWARE\Policies\Microsoft\Windows\System" /v "RunAsPPL" /t REG_DWORD /d "00000001"

or similarly with other non-zero DWORD values like "00000002".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd Review Needed PR need a second approval Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants