Skip to content

build(go): upgrade purego to v0.8.4 #8159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

build(go): upgrade purego to v0.8.4 #8159

merged 4 commits into from
Jun 5, 2025

Conversation

grandwizard28
Copy link
Collaborator

@grandwizard28 grandwizard28 commented Jun 4, 2025

📄 Summary

There was some regression in the go toolchain here: golang/go#73617 which was causing build issues for darwin.

The issue was happening for github.com/ebitengine/purego. They have fixed it here: ebitengine/purego#312 and released a new version.


Important

Upgrade purego to v0.8.4 to fix Darwin build issues caused by a Go toolchain regression.

This description was created by Ellipsis for 8d99630. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a6638ef in 55 seconds. Click for details.
  • Reviewed 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. go.sum:210
  • Draft comment:
    Purego has been bumped from v0.8.0 to v0.8.4 and the corresponding checksums updated accordingly. This update appears to be correct and in line with the intended upgrade.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_jZDsJ3JmI0xxXznX

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 8d99630 in 57 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. go.sum:1
  • Draft comment:
    This go.sum update is extremely large – it reflects many dependency checksum changes. Please confirm that these changes were intentionally generated via a 'go mod tidy' (or equivalent) run and that the corresponding go.mod updates are aligned. Verify that no unexpected or insecure dependency versions have been introduced.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_Ok8XP4dBw4P3QZb6

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@grandwizard28 grandwizard28 enabled auto-merge (squash) June 5, 2025 12:23
@grandwizard28 grandwizard28 merged commit ba0ba4b into main Jun 5, 2025
13 checks passed
@grandwizard28 grandwizard28 deleted the fix/binary-build branch June 5, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants